feature: refactor get address function #237
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xxxigm
requested review from
DonFungible,
edisonz0718,
jacob-tucker and
AndyBoWu
as code owners
bonnie57
reviewed
Mar 3, 2025
There was a problem hiding this comment.
Hi @xxxigm ,
Thank you so much for your contribution and for taking the time to submit this PR! We really appreciate your effort and insights.
It looks like the code in this PR is outdated, and we’ve already refactored the code about this logic.
For now, I’ll go ahead and close this PR, but please don’t hesitate to reach out if you have any further suggestions or questions. Your contributions are always welcome!
Thanks again for your support and for helping us improve! 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor get address function
Example:
This pr adds user login function, includes：
1.Using Positive Condition: The refactored code checks if the address is valid (if (isAddress(...))), making it clearer and more readable compared to the original code's negative condition (if (!isAddress(...))).
2.Improved Error Handling: The refactored code uses new Error(...), which is best practice.
3.Enhanced Readability: Minor punctuation adjustments were made in the error message for better clarity.